Improve "Reference in new issue" modal #30547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
silverwind
added
backport/v1.22
pull-request-size
bot
added
size/M
github-actions
bot
added
the
modifies/templates
delvh
approved these changes
Apr 17, 2024
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Apr 17, 2024
GiteaBot
added
lgtm/done
|
Selection state also fixed: 
|
wxiaoguang
reviewed
Apr 18, 2024
web_src/css/base.css
Outdated
| .ui.search.dropdown > .text { | ||
| white-space: nowrap; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; |
There was a problem hiding this comment.
Why only "search dropdown" has these styles, but all ".ui.dropdown .menu > .item" also have "text-overflow: ellipsis" ?
There was a problem hiding this comment.
Not sure if that's the best selector but it was one of the matching ones in this case. The classname on it is certainly some kind of abuse ui search normal selection dropdown.
There was a problem hiding this comment.
I removed the search class from the selector, but would not do any more change to this currently. Actually I'm not sure I understand the question.
There was a problem hiding this comment.
OK, I think the problem is clear now. We can't "overflow: hidden" to any general "dropdown" selector.
Because even .ui.selection or .ui.search it might contain images like avatars.
The dropdown was not designed to work this way.
Ref: Broken avatar css on main page #30624
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 18, 2024
Fixes: go-gitea#29994 Also some misc enhancements done to the form in the modal. <img width="840" alt="Screenshot 2024-04-17 at 23 02 55" src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43">
silverwind
added a commit
that referenced
this pull request
Apr 18, 2024
Backport #30547 by @silverwind Fixes: #29994 Also some misc enhancements done to the form in the modal. <img width="840" alt="Screenshot 2024-04-17 at 23 02 55" src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43"> Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 19, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Mock queue backoff duration (go-gitea#30553) Improve "Reference in new issue" modal (go-gitea#30547) Add a few root files to lint-spell (go-gitea#30530) Refactor and fix archive link bug (go-gitea#30535) Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555) Some following up changes for routes (go-gitea#30550) Add form field id generation, remove duplicated ids (go-gitea#30546) Fix border-radius on view, blame and code search (go-gitea#30545) Disable enter key for accepting code completion in Monaco (go-gitea#30548)
silverwind
pushed a commit
that referenced
this pull request
Apr 21, 2024
Follow #30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. 
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 21, 2024
Follow go-gitea#30547 (comment) Fix go-gitea#30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text. 
lunny
pushed a commit
that referenced
this pull request
Apr 22, 2024
Backport #30628 by @wxiaoguang Follow #30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text.  Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Apr 22, 2024
Follow go-gitea/gitea#30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text.  (cherry picked from commit 1e4867730b261352d63098b85cf53ca05867c8c2) (cherry picked from commit 112df5a)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Apr 22, 2024
Follow go-gitea/gitea#30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text.  (cherry picked from commit 1e4867730b261352d63098b85cf53ca05867c8c2)
uli-heller
pushed a commit
to uli-heller/forgejo
that referenced
this pull request
Apr 24, 2024
Follow go-gitea/gitea#30547 (comment) Fix #30624 The Fomantic UI Dropdown wasn't designed to work that way, its "text" element might contain images. So the "overflow" shouldn't be added to any general dropdown text.  (cherry picked from commit 1e4867730b261352d63098b85cf53ca05867c8c2) (cherry picked from commit 112df5a)
wxiaoguang
added
the
skip-changelog
|
-> Fix some UI problems (dropdown/container) #30849 |
wxiaoguang
added a commit
that referenced
this pull request
May 6, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 6, 2024
Follow go-gitea#30345 Follow go-gitea#30547 `ellipsis` / `white-space` shouldn't be put on the general dropdown components.
wxiaoguang
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29994
Also some misc enhancements done to the form in the modal.